-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide TagTrait to replace ScenarioTagTrait. #510
Conversation
I have split up the original
The |
This is failing on PHP 5.5 since the PR is using argument unpacking which was introduced in PHP 5.6. @jhedstrom are you planning on still supporting PHP 5.5 on the 4.x branch? |
@pfrenssen I'd prefer not to. Honestly, I'd love to only support 7.x, but don't know if that will work for folks still running Drupal 6 or not. |
Maybe we should do a poll on Twitter to see if people are still interested in Drupal 6 support for BDE 4.x? We could also maybe decide to keep supporting 3.x for D6 only, say for one or two years more? We could keep all D7 and D8 issues for 4.x. I don't think this will be a lot of additional maintenance work, I haven't seen many D6 issues in the queue lately :) I personally would love to move to PHP 7 for the 4.x branch. But I think we should wait a few months, PHP 5.6 is still officially supported until December of this year. |
Added support for PHP 5.5, we can have the discussion about which PHP and Drupal versions to support in the future in a dedicated issue :) |
Makes sense to me! Thanks! |
Fixes #509.